Project

General

Profile

Actions

Task #1853

closed

Disabled module shows error in Scheduled tasks

Added by Alena Peterová over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Long running task
Target version:
Start date:
09/13/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Version 9.7.6
Switch to the "Scheduled tasks" when the module "rec" is disabled:

But there is not scheduled task coming from this module - so why the error?


Files

disabled_rec_module.png (10.2 KB) disabled_rec_module.png Alena Peterová, 09/13/2019 04:49 PM

Related issues

Related to IdStory Identity Manager - Defect #1878: Scheduled task for synchronization is deleted after server is restarted.ClosedRadek Tomiška09/26/2019

Actions
Related to IdStory Identity Manager - Task #1442: Fix lrt SelectCurrentContractSliceTaskExecutorClosedRadek Tomiška01/11/2019

Actions
Actions #1

Updated by Radek Tomiška over 5 years ago

  • Subject changed from Disabled module rec shows error in Scheduled tasks to Disabled module shows error in Scheduled tasks
  • Category changed from Recertification to Long running task
  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version set to Rhyolite (9.7.7)
  • % Done changed from 0 to 90

Module recertification contains task ''RecertificationDueDateWarningTaskExecutor''. When module is disabled, this warning is shown.

I've added support for disabling LTRs:
- when module is disabled (or single LRT by configuration), then raw task type is shown in scheduled tasks agenda (without exception)
- task cannot be executed until module is enabled again (even when is scheduled, then nothing is done for disabled tasks, just LOG with warning on attempt).

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/3b115f4a5ec7890c3299dbc6d7c54d63e75ef0f1

Could you do a feedback, please?

Workaround for situation described in this ticket: Remove (uninstall) disabled module.

Actions #2

Updated by Vít Švanda over 5 years ago

  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I did review and test. Works fine. I found one iteresting scenario. When I create the scheduled task (I don't have automatically start this tasks) and then I disable the module. Then I can se on the tab All tasks my task and this can be run (run selected tasks). After that task end with exception "Task has invalid configuration", because he tried to call disabled service.
So may be could be that task not started (if module is disabled), but may be is this scenario too much.

This is OK, for me.

Actions #3

Updated by Radek Tomiška about 5 years ago

  • Status changed from Needs feedback to Resolved

Thx for feedback, module is disabled exception is now propagated directly into task result:
https://github.com/bcvsolutions/CzechIdMng/commit/d52596ffceebbba2f9f23d52d8bb59e3486cbde5#diff-19af9d66c43a6649bec7d2316faf2ef3

Actions #4

Updated by Radek Tomiška about 5 years ago

  • Status changed from Resolved to Closed
Actions #5

Updated by Radek Tomiška about 5 years ago

  • Related to Defect #1878: Scheduled task for synchronization is deleted after server is restarted. added
Actions #6

Updated by Radek Tomiška about 5 years ago

  • Related to Task #1442: Fix lrt SelectCurrentContractSliceTaskExecutor added
Actions

Also available in: Atom PDF