Project

General

Profile

Actions
Copy link

Defect #185

closed

FE: Content is not refresh after reusing same component

Added by Vít Švanda over 7 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Frontend
Target version:
Beryl
Start date:
11/08/2016
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Content is not refresh after reusing same component.

When we have content (page) for some entity and we will go to another entity (using same component) , then content of component will be not fully changed (refreshed for new entity).
This problem occurs only if previous component did not unmount (react use same instance of this component).
For example that problem occurs on detail history of workflow process (and on many others).

This problem can be fixed with correct using method componentDidMount and componentWillReceiveProps (correct implementation is maybe in SchemaAttribute.js)

Actions
Copy link
 #1

Updated by Vít Švanda over 7 years ago

  • Assignee changed from Vít Švanda to Ondřej Kopr

Ondra, pls try fix this problem on workflow history. I am open for consultation.

Actions
Copy link
 #2

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Ondřej Kopr to Vít Švanda
  • % Done changed from 0 to 20

On component HistoricProcessInstanceDetail, was created _initComponet. Add reload diagram and force searchParams in subprocess table.

Please check if my solutions is correct. Commit: https://github.com/bcvsolutions/CzechIdMng/commit/fc0890a9bdfe0c08efe00bcf41b260e5de7df3f3

Actions
Copy link
 #3

Updated by Vít Švanda over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondřej Kopr

It looks OK, but tasksTable reload not working.

Actions
Copy link
 #4

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Vít Švanda
  • ForceSearchparameters is now in state,
  • reload table with task is now correct.
Actions
Copy link
 #5

Updated by Vít Švanda over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondřej Kopr
Actions
Copy link
 #6

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • In last commit is changed props update in component table please check my solutions.
Actions
Copy link
 #7

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I did review, test and some improvments:
  • In advanced table method 'componentWillReceiveProps' - be the second reload in 'else if' statement to prevent duplicit reload.
  • added is equals method to SearchParameters (unit test included)
  • now it works as expected .)

Please add this solution to other problematic places.

Actions
Copy link
 #8

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 20 to 100

This task will be closed for this release (Beryl) - this soutions will implemented to another component durign development next release (Citrin)

Actions
Copy link
 #9

Updated by Radek Tomiška about 5 years ago

  • Tracker changed from Task to Defect
  • Subject changed from Bug - Content is not refresh after reusing same component to FE: Content is not refresh after reusing same component
  • Category changed from 20 to Frontend
Actions
Copy link

Also available in: Atom PDF