Task #1827
closed
Entity state agenda: add result code column and filter by result state and code.
100%
Description
- Add code column with result code into entity state agenda.
- Add filter by result state and result code
Related issues
Updated by Radek Tomiška over 4 years ago
- Related to Feature #915: Add entity state agenda added
Updated by Artem Kolychev over 4 years ago
- Status changed from New to In Progress
Updated by Artem Kolychev over 4 years ago
https://github.com/bcvsolutions/CzechIdMng/tree/artem/1827-extend-entity-state-table
#1827 added result state and code columns for entity state agenda + test for it
Updated by Artem Kolychev over 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Radek Tomiška
https://github.com/bcvsolutions/CzechIdMng/compare/artem/1827-extend-entity-state-table
added filter by result state and code.
Updated by Radek Tomiška over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Artem Kolychev
- Target version set to Rhyolite (9.7.7)
- % Done changed from 0 to 100
I did test and feedback. Newly added column and filters work, thx! Code looks nice also, i like it (except tests :), see below).
I fixed / changed:
- Added filter criteria to prevent mixin states from other tests.
- Test IdmEntityStateControllerRestTest#testOperationStates checked returned size only (random states from other tests can be returned).
- list of states is initialized in filter now.
- layout was changed for UI table => date filter was broken. Used the same layout as for entity event table.
- and renamed some fields and columns to be the same as on other place.
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/8c358243f79d93f4ad8b9e77560ed9b8783ff3ae
Merged into develop.
Updated by Radek Tomiška over 4 years ago
- Status changed from Resolved to Closed