New agenda basically works, thx. I think this agenda will be usefull i hope so (for developers / api consultants).
But i changed a lot of things - something we spoke of before, but it wasn't implemented properly ... and some other (see bellow).
Changes / fixed (code review) :
- Removed wrong field 'text' from 'FilterBuilderDto' (text field doesn't exist for filter builder).
- Added template of 'BaseEntity' for field 'entityClass' used in 'FilterBuilderDto' (warning was shown).
- Changed type of field 'filterBuilderClass' to 'Class>' (the same convention as for 'entityClass' field).
- Redundant field 'entityType', 'disabled' removed (we spoke before).
- 'serialVersionUID' missed in 'FilterBuilderDto'.
- Layout for agenda fixed - column order, filter layout ("The agenda will be the same as Setting > Modules > Processors."), no data alert added, wrong structure, errors and warnings, forgotten event type ...
- Removed redundant field 'text' 'FilterBuilderFilter' (see 'DataFilter' generalization).
- Removed redundant field 'entityType' 'FilterBuilderFilter' (the same as dto).
- Removed unimplemented field 'disabled' 'FilterBuilderFilter'.
- 'FilterBuildersFilterUnitTest' removed - test used random filter returned from context and checks size of returned filters only - new unit test will be created.
Implemented (added):
- added property 'id' to FilterBuilder interface - filled automatically from spring bean name.
- added implementation for find by 'text' (same as entity processors)
- added implementation for find by 'entityClass' (same as entity processors)
- added showing internally implemented filters directly in service.
I will continue with showing, which filter is used currently (by configuration) and implement new integration tests.
