Task #1788
closed
Code review: new columns in IdentityRoleReport
100%
Description
Can you please review the code? The code is here:
https://git.bcvsolutions.eu/modules/reports/tree/18306_tomasdoischer_role_report_new_attrs
The project redmine code is 18306.
Thank you!
Updated by Radek Tomiška over 4 years ago
- Assignee changed from Radek Tomiška to Tomáš Doischer
As we speak before on slack, this report cannot be merged into product, because contains project specific feature, see:
https://git.bcvsolutions.eu/modules/reports/blob/18306_tomasdoischer_role_report_new_attrs/Realization/backend/reports/src/main/java/eu/bcvsolutions/idm/reports/dto/RptContractAttributesDto.java#L7
https://git.bcvsolutions.eu/modules/reports/blob/18306_tomasdoischer_role_report_new_attrs/Realization/backend/reports/src/main/java/eu/bcvsolutions/idm/reports/dto/RptContractAttributesDto.java#L18
...
Fill some of "Contract attribute value" reqiuered by project logic doesn't make sence for product. This report is "Identities and their roles". If some information about contract is needed, then why whole contract is not rendered (with all attributes)?
Updated by Tomáš Doischer about 4 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
I'm closing this ticket, it is no longer relevant. The report got merged in the product after code-review but no mention of it is found here.
Updated by Tomáš Doischer about 4 years ago
- Status changed from Resolved to Closed