Actions
Task #1756
closed
Add filtering by system state to role-request table
Start date:
07/22/2019
Due date:
% Done:
100%
Estimated time:
4.00 h
Owner:
Description
System state is implemented in branch: vsvanda/1736-state-of-role-request
Include the tests.
Updated by Artem Kolychev over 4 years ago
- Status changed from New to In Progress
Updated by Artem Kolychev over 4 years ago
added filter by system state
created Rest tests
branch: https://github.com/bcvsolutions/CzechIdMng/compare/artem/1756-state-of-role-request
Updated by Artem Kolychev over 4 years ago
- Assignee changed from Artem Kolychev to Vít Švanda
Updated by Artem Kolychev over 4 years ago
- Status changed from In Progress to Needs feedback
Updated by Vít Švanda over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Artem Kolychev
I did review. Works correctly, good job.
I found some small issues:
- Field in filter has name "resultStates" -> better is "systemStates".
- Responsive design in filter is broken (too small value of filtering buttons and data component)
- Wrong author in test (You are not Tomiska ;) ).
I fixed this small issues in commits below:
https://github.com/bcvsolutions/CzechIdMng/commit/9ca1519be812990dd7f019e1bd06689631cf89c2
https://github.com/bcvsolutions/CzechIdMng/commit/05feada21e0f01cbb263c804b20613513f6fb463
Updated by Artem Kolychev over 4 years ago
- Status changed from Resolved to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
Updated by Vít Švanda over 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Artem Kolychev
Again, you are definitely not a Tomiška:
https://github.com/bcvsolutions/CzechIdMng/commit/00fd3bd91b9aa722912e2a86378f1b062a8e0c58
Actions