Project

General

Profile

Actions

Task #1755

closed

Create tests for filter workflow process definition

Added by Vít Švanda over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Artem Kolychev
Category:
Test
Target version:
Start date:
07/22/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Service for workflow definition process (DefaultWorkflowProcessDefinitionService) has bad tests coverage. Please improve it.

https://sonar.bcvsolutions.eu/component_measures/metric/coverage/list?id=eu.bcvsolutions.idm%3Aidm-core

- Inspiration: HistoryProcessAndTaskTest, DeployAndRunProcessTest

Actions #1

Updated by Artem Kolychev over 4 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Artem Kolychev over 4 years ago

  • Status changed from In Progress to Needs feedback
Actions #3

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to In Progress

I made review. It is Ok and works. Good job.

I found some issues:
  • Rename the test file from "SelectTest " to "DefaultWorkflowProcessDefinitionServiceFilterTest"
  • For next please add number of the redmine ticket to the description of commit ("created automatically test for selection and filtering workflow proce").
  • Please remove all tests for load a diagram. We don't want have tests for expect "NullPointerException" (this situations should be fixed instead) :-).
Actions #4

Updated by Artem Kolychev over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Artem Kolychev to Vít Švanda
Actions #5

Updated by Vít Švanda over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Artem Kolychev
  • % Done changed from 0 to 100

It looks nice. I merged it to the develop. Thanks for that.

Actions #6

Updated by Artem Kolychev over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF