Project

General

Profile

Actions
Copy link

Task #1700

closed

Optimisation of manual contract end

Added by Marcel Poul almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Contractual relationship
Target version:
Quartz (9.6.3)
Start date:
05/29/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

When we end the contract and the user has many roles - hundreds, the operation takes too much time. The aim of this ticket is to optimise it.
There are 2 ways of optimisation
  • profiling the process and optimisation
  • make the process asynchronous

I vote the first one now to see, why it is slow and see if we can make it quicker in some reasonable time. Then discuss which way we can go.

Related issues

Related to IdStory Identity Manager - Defect #1727: Failed event during manual contract end with automatic rolesClosedRadek Tomiška06/21/2019

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška almost 5 years ago

I'm sure the first option is related to standard behavior with role requests (+acm, +provisioning).

Actions
Copy link
 #3

Updated by Radek Tomiška almost 5 years ago

  • Category set to Contractual relationship
  • Status changed from New to In Progress
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • Target version set to Quartz (9.6.3)
Actions
Copy link
 #4

Updated by Radek Tomiška almost 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90

I switched removing assigned roles to be asynchronous, when contract ends:
https://github.com/bcvsolutions/CzechIdMng/commit/af0f6b60918448868dac18ac7d30cdcca3397cdc

Could you do a feedback, please?

Note: Other UC, e.g when contract is deleted will be solved in future by 'deleted' flag.

Actions
Copy link
 #5

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 90 to 100

Asynchronously removing the assigned roles works perfectly. I also tested classic HR processes and during HrEndContractProcess is removing also asynchronously.

Thank you for that.

Actions
Copy link
 #6

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #7

Updated by Alena Peterová almost 5 years ago

  • Related to Defect #1727: Failed event during manual contract end with automatic roles added
Actions
Copy link

Also available in: Atom PDF