Project

General

Profile

Actions

Task #1692

closed

Move table of role-concepts from FE to BE

Added by Vít Švanda almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Roles
Target version:
Start date:
05/24/2019
Due date:
% Done:

100%

Estimated time:
56.00 h
Owner:

Description

  • Move table of role-concepts from FE to BE
  • Remove list of concepts for request DTO.

Related issues

Related to IdStory Identity Manager - Task #89: Bulk action - change valid from - till dates for role request conceptsNew08/09/2016

Actions
Actions #1

Updated by Radek Tomiška almost 5 years ago

I've added quick improvement, before list of concepts will be removed from request:
https://github.com/bcvsolutions/CzechIdMng/commit/42e10f6a900a65359de3d97104e63651b3c51cd5

Now are concepts loaded in less number of selects (fetch mode is applied now - see #1619)

Actions #2

Updated by Radek Tomiška almost 5 years ago

  • Target version changed from Quartz (9.6.3) to Rhyolite (9.7.0)
Actions #3

Updated by Vít Švanda almost 5 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Vít Švanda almost 5 years ago

  • Estimated time set to 48.00 h
Actions #5

Updated by Vít Švanda almost 5 years ago

  • Estimated time changed from 48.00 h to 56.00 h
Actions #6

Updated by Vít Švanda almost 5 years ago

Implemented. Everythin is in the develop.

Tests remains.

Documentation:

The table of user roles changes has been redesigned. All logic was move from frontend to backend. This new table (RequestIdentityRoleTable) is pageable, sorting, filtering on backend now.
- For this table was created new DTO ``IdmRequestIdentityRoleDto``, representing change for specific identity-role entity.
- For this table was created new REST endpoint too ``/request-identity-roles``. This endpoint can be calling with starndard CRUD operations. Logic in this REST (service ``IdmRequestIdentityRoleService``) will be automatically creates role-concepts.
- The finding method in this serivce compiles assigned identity-roles and role-concepts together and returns list of ``IdmRequestIdentityRoleDto``.
- Sorting works separatly for identity-roles and concepts. For this reason are first returns concepts adding new assign roles. Then are returns currentlly assigned identity-roles. If for returns identity-role exists remove or update concept, then is identity-role marked as changed. Role-concepts and identity-roles are always returns as ``IdmRequestIdentityRoleDto``.
- For performance reasons, the REST endpoint for role-request, returns request without concepts (from this version)! For same reason ``IdmRoleRequestService`` doesn't returns concepts in the request from now. If you need to get request with a concepts, you can use this:

    roleRequestService.get(requestId, new IdmRoleRequestFilter(true));
Actions #7

Updated by Vít Švanda almost 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška

Tests was created, coverage is 77 % now.

Please could you make a review? Sorry for too many commits :-).

https://github.com/bcvsolutions/CzechIdMng/search?o=desc&q=1692&s=committer-date&type=Commits

Actions #8

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

I did test and feedback. Toogle button to show changes only is awesome like this whole feature, thx! Review notes:
- add support for filtering by more environment to concepts
- slash is shown, when state in systems is empty
- MessageFormat used in logger is redundant

Actions #10

Updated by Vít Švanda over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
Actions #11

Updated by Vít Švanda over 4 years ago

After supports for filtering by environments was added some tests doesn't pass. Problem was in the identityRoleFilter - fixed.

https://github.com/bcvsolutions/CzechIdMng/commit/0aebbe96d17c3c941ff8b856957d2d2df1c8c60f

Actions #12

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

Thx for fix typo in IdmIdentityRoleFilter (i have to create some util method in parameter converter to prevent mistakes).

Fixes above works, thx. Except slash, i fixed it:
https://github.com/bcvsolutions/CzechIdMng/commit/3585d828abf8bcfa68b38d072e569e203d9f9dbb

Note: environment field in IdmConceptRoleRequestFilter is redundant and unused now (added duplicate environments).

Actions #13

Updated by Vít Švanda over 4 years ago

  • Status changed from Resolved to Closed
Actions #14

Updated by Radek Tomiška over 4 years ago

  • Related to Task #89: Bulk action - change valid from - till dates for role request concepts added
Actions

Also available in: Atom PDF