Project

General

Profile

Actions
Copy link

Defect #1656

closed

Null pointer in deduplication with valid till

Added by Ondřej Kopr almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Roles
Target version:
Quartz (9.6.1)
Start date:
05/16/2019
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

This is when IdM tries compare valid till

java.lang.IllegalArgumentException: Partial cannot be null
        at org.joda.time.base.AbstractPartial.isBefore(AbstractPartial.java:373)
        at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmIdentityRoleService.isIdentityRoleDatesDuplicit(DefaultIdmIdentityRoleService.java:472)
        at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmIdentityRoleService.getDuplicated(DefaultIdmIdentityRoleService.java:397)
        at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmIdentityRoleService$$FastClassBySpringCGLIB$$95d3a388.invoke(<generated>)
        at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
        at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:651)
        at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmIdentityRoleService$$EnhancerBySpringCGLIB$$56fa76d4.getDuplicated(<generated>)
        at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRoleRequestService.markDuplicates(DefaultIdmRoleRequestService.java:853)
        at eu.bcvsolutions.idm.core.model.service.impl.DefaultIdmRoleRequestService$$FastClassBySpringCGLIB$$aec38c95.invoke(<generated>)
        at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)

Affected version: 9.6.0

Files

Download all files
request.gif (611 KB) request.gif Ondřej Kopr, 05/16/2019 07:51 AM
dupl3.png (22.1 KB) dupl3.png Ondřej Kopr, 05/16/2019 08:31 AM
dupl2.png (23.1 KB) dupl2.png Ondřej Kopr, 05/16/2019 08:31 AM
Actions
Copy link
 #1

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Ondřej Kopr almost 5 years ago

  • File dupl3.png dupl3.png added
  • File dupl2.png dupl2.png added
  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

I add check for valid till for second identity role into process check duplicate. Now can exists these scenarios:

In this example is not filled valid till on contract.

In this example is filled valid till on contract with date 17.5.

I also update behavior with mark duplicities, because before was marked as duplicity concept that is not duplicit but some another identityRole is duplicit with them. This is also mistake. Tests are included.

commit: https://github.com/bcvsolutions/CzechIdMng/commit/010f4f4609e43f7dbfdc31d8ee023c7f334db946 (develop)

Please Radek could you make a review? Or Vitek :). Thank you.

Actions
Copy link
 #4

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did test and review, it works, thx!

Actions
Copy link
 #5

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF