Project

General

Profile

Actions

Task #1639

closed

Don't create role-request concept before first save

Added by Vít Švanda over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Roles
Target version:
Start date:
05/06/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Related issues

Related to IdStory Identity Manager - Defect #1699: Empty role request is created when trying to add non-existent roleClosedRadek Tomiška05/28/2019

Actions
Actions #1

Updated by Vít Švanda over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 0 to 90

I changed behavior, so now is request created after user:

Click on the save, add some new roles, remove existing role, update existing role, add some role from the other user.

Warning, be careful in the feedback ;).

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/daed8ee4a94589c7bd20064e3cd6192552af0ff0

Actions #2

Updated by Vít Švanda over 5 years ago

  • I removed redundant call of identity roles.
  • I didn't found simple solution for prevent redundant call for check incompatible roles.
  • Applicant and implementer is show only if ids are in the request.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/5b10fc574e5d4e9a25228718b25f76e05f9f7ff9

Actions #3

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100
Actions #4

Updated by Radek Tomiška over 5 years ago

I did test and code review, it works as comments above says, thx!

Actions #5

Updated by Vít Švanda over 5 years ago

  • Status changed from Resolved to Closed
Actions #6

Updated by Radek Tomiška over 5 years ago

  • Related to Defect #1699: Empty role request is created when trying to add non-existent role added
Actions

Also available in: Atom PDF