Project

General

Profile

Actions

Task #1631

closed

Deduplication use _eavs instead of getSubDefinition

Added by Ondřej Kopr almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Roles
Target version:
Start date:
05/02/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Please in method equalsSubdefinitions is get for subdefinition and check values. Change this behavior that subdefinition with values will be get from _eavs instead of new get into database.


Related issues

Related to IdStory Identity Manager - Feature #1638: Warn user about new duplicities during creating new role conceptClosedRadek Tomiška05/06/2019

Actions
Actions #1

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from New to In Progress
  • Target version set to Quartz (9.6.0)
Actions #2

Updated by Ondřej Kopr almost 5 years ago

  • % Done changed from 0 to 10
Actions #3

Updated by Ondřej Kopr almost 5 years ago

In this ticket will be also implemented flag duplicities during creating request including future subroles.

Actions #4

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 10 to 90

The whole implementation was finished,

Now is possible use method removeDuplicities and markDuplicities in projects and on frontend agenda.

commit: https://github.com/bcvsolutions/CzechIdMng/commit/5b3794458cb9f3acf9887bfa6524041125dc07b5 (branch: develop)
documentation: https://wiki.czechidm.com/devel/documentation/roles/dev/identity-role-deduplication#concept_role_request_deduplication

Please Radek could you make a review? Thank you.

Actions #5

Updated by Ondřej Kopr almost 5 years ago

  • Related to Feature #1638: Warn user about new duplicities during creating new role concept added
Actions #6

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 70

I did test and after consultation we need to add this features:
- flag duplicate will contain true / false
- duplicate can be found in concepts too
- list of duplicates will be placed in embedded as lists of uuid (identity roles vs concepts)

Actions #7

Updated by Ondřej Kopr almost 5 years ago

Check for concept was added. Now is returned lists of duplicates for concepts with another concepts and identity roles.

Reaming: tests

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/ff0ea2ed2133bd8d259da5cb8256fb1e60b8a5ec

Actions #8

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 70 to 90

Tests and moving method for mark concepts into different place: https://github.com/bcvsolutions/CzechIdMng/commit/4eb4525f6aef3683a963c70b59e3c0722d19f1dd

Please Radek could you continue with testing and implementing #1638 thank you.

Actions #9

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did test and review, it works and code looks nice, thx!

Actions #10

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF