Project

General

Profile

Actions
Copy link

Task #1587

closed

Task #1560: Testing of the product (9.5.0)

2 pull requests pending (language edit) since Feb 22

Added by milus kotisova about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
milus kotisova
Category:
UX
Target version:
Quartz (9.6.0)
Start date:
03/27/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

https://github.com/bcvsolutions/CzechIdMng/pulls

Can you merge these please?

I would like to continue editing, I already have a further list of notes.
Generally, when's the best time to make language changes - and merge them with releases?

Files

Download all files
001.png (36.6 KB) 001.png Ondřej Kopr, 03/27/2019 02:23 PM
002.png (55.5 KB) 002.png Ondřej Kopr, 03/27/2019 02:23 PM
commit.png (22.3 KB) commit.png Ondřej Kopr, 03/27/2019 02:35 PM
Actions
Copy link
 #1

Updated by Ondřej Kopr about 5 years ago

Vitek already merged your changes in his branch on Mar 19, 2019:

This way how to notify someone that he must made for me some work is not nice. Please don't create these tickets, you can use slack or mobile for check in which status is some work.

Otherwise we all look at your changes before. The changes that you did isn't probably what you really want. For example:

  • You want probably edited localization in password change form (after login), but you didn't edit anything on this detail:
  • you edited the public password change and now localization message are very different in cz/en:

Did you try your changes? Someone must now check all places :( that you edit and check if it correct in both languages and this is really boring and long work and now we all have different more priority work. But :) you can continue with correction, it is not required to wait for these changes, or not?

For future speed up you can edit more files in one branch and send it at the once.

Actions
Copy link
 #2

Updated by Radek Tomiška about 5 years ago

  • Status changed from Needs feedback to Closed
  • Target version set to Quartz (9.6.0)
  • % Done changed from 0 to 100

Vitek removed part of changes with issues above and I merged both branches into develop.

Thx for this localization improvements.

Actions
Copy link
 #3

Updated by milus kotisova about 5 years ago

Thank YOU.
And sorry about the extra pain.

From now on, I will always create a ticket beforehand, then add the number of the ticket in the commit with a short description, and pass it on.

Actions
Copy link

Also available in: Atom PDF