Project

General

Profile

Actions
Copy link

Defect #1577

closed

Task #1560: Testing of the product (9.5.0)

Non-responsive button when selecting a role from a catalog

Added by milus kotisova over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Roles
Target version:
Pyrite (9.5.1)
Start date:
03/26/2019
Due date:
% Done:

100%

Estimated time:
6.00 h
Affected versions:
Owner:

Description

@affected version 9.4.0
@affected version 9.5.0

Actions
Copy link
 #1

Updated by milus kotisova over 5 years ago

  • File deleted (non-responsive_button-min_2.gif)
Actions
Copy link
 #2

Updated by milus kotisova over 5 years ago

Gif sent by email.

Actions
Copy link
 #3

Updated by Ondřej Kopr over 5 years ago

  • Assignee changed from Vít Švanda to Ondřej Kopr
Actions
Copy link
 #4

Updated by Ondřej Kopr over 5 years ago

I confirm the bug.

The issues is probably on forntend component:

Log:

Uncaught TypeError: Cannot read property 'identityRoleAttributeDefinition' of undefined
    at t.value (app.js:sourcemap:181)
    at t.value (app.js:sourcemap:148)
    at Object.r (app.js:sourcemap:99)
    at i (app.js:sourcemap:97)
    at Object.s [as executeDispatchesInOrder] (app.js:sourcemap:97)
    at p (app.js:sourcemap:97)
    at m (app.js:sourcemap:97)
    at Array.forEach (<anonymous>)
    at r (app.js:sourcemap:100)
    at Object.processEventQueue (app.js:sourcemap:97)

Code from log:

if (!_lodash2['default'].isArray(originalValue) || originalValue.length === 1) {
        selectedRole = _lodash2['default'].isArray(originalValue) ? originalValue[0] : originalValue;
        if (selectedRole.identityRoleAttributeDefinition) {
          this.context.store.dispatch(roleManager.fetchAttributeFormDefinition(selectedRole.id, uiKeyRoleAttributeFormDefinition + '-' + selectedRole.id, function (json, error) {
            _this2.handleError(error);
          }));
        }
      } else {
        selectedRole = null;
      }

Actions
Copy link
 #5

Updated by Ondřej Kopr over 5 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Ondřej Kopr over 5 years ago

  • % Done changed from 0 to 70

The issues was fixed, but I explore some strange behavior with role parameters and select role by Advanced.RoleSelect component.

Actions
Copy link
 #7

Updated by Ondřej Kopr over 5 years ago

  • Target version set to Quartz (9.6.0)
Actions
Copy link
 #8

Updated by Vít Švanda over 5 years ago

  • Estimated time set to 6.00 h
Actions
Copy link
 #9

Updated by Ondřej Kopr over 5 years ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška

I fixed the broken button. But still there exists some strange behavior with remove last role with parameter. After remove the role there still exists form with eavs. Render method isn't called :( Please Radek could you check this state? Thank you.

There is my changes:
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/7aa4b6f1634fe0d49a93d9bd10139631708111aa (branch: develop)

Actions
Copy link
 #10

Updated by Radek Tomiška over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • Target version changed from Quartz (9.6.0) to Pyrite (9.5.1)
  • % Done changed from 70 to 90

I fixed selected role removal - eav form is hidden now:
https://github.com/bcvsolutions/CzechIdMng/commit/ca2901b1591d1b09032b3c7845c015fcd44d51ae

I cherry picked both commits into version 9.5.1, fix will be there.

Could you do a feedback please?

Actions
Copy link
 #11

Updated by Radek Tomiška over 5 years ago

  • Description updated (diff)
Actions
Copy link
 #12

Updated by Vít Švanda over 5 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Vít Švanda to Ondřej Kopr
  • % Done changed from 90 to 100

I checked it and this two problems was fixed. Thanks for both of you.

Actions
Copy link

Also available in: Atom PDF