Project

General

Profile

Actions
Copy link

Task #1575

closed

Optimalization of role-requests (search, save)

Added by Vít Švanda over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Roles
Target version:
Quartz (9.6.0)
Start date:
03/25/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Related issues

Related to IdStory Identity Manager - Defect #1789: You are not able to save role request on approval taskClosedVít Švanda08/09/2019

Actions
Actions
Copy link
 #1

Updated by Vít Švanda over 5 years ago

Optimalizations:

ReadOnly annotation removed from the role-request and concept-role-request -> removed time expensive select in the method toEntity.
Removed useless and expensive check in start of request.

https://github.com/bcvsolutions/CzechIdMng/commit/e5a057fe922ee9f703094f86522feb89c2f153f0
https://github.com/bcvsolutions/CzechIdMng/commit/48e40892ac807b073e9c79e5f7ce0770fa839499

Actions
Copy link
 #2

Updated by Vít Švanda over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
Actions
Copy link
 #3

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 100

I did test and code review, it works (we moved filling of concept state to FE) and code looks nice, thx!

Actions
Copy link
 #4

Updated by Vít Švanda over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #5

Updated by Vít Švanda over 5 years ago

  • Status changed from Closed to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
Actions
Copy link
 #6

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda

I did test, it works, thx!

Actions
Copy link
 #7

Updated by Radek Tomiška over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #8

Updated by Radek Tomiška over 5 years ago

I've added another slight improvement of role request detail - preloaded roles from concepts are used for checking incompatible roles (-1 select):
https://github.com/bcvsolutions/CzechIdMng/commit/32df4611c9fc841f2f0b9c010de03cf7b54a70fd

Actions
Copy link
 #9

Updated by Radek Tomiška over 5 years ago

  • Related to Defect #1789: You are not able to save role request on approval task added
Actions
Copy link

Also available in: Atom PDF