Project

General

Profile

Actions

Task #1543

closed

Make execution of role-request async

Added by Vít Švanda almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Roles
Target version:
Start date:
03/08/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Files

role-request-pool.png (125 KB) role-request-pool.png Vít Švanda, 03/29/2019 09:44 AM

Related issues

Related to IdStory Identity Manager - Task #1534: Incremental account management and provisioningClosedVít Švanda02/25/2019

Actions
Related to IdStory Identity Manager - Task #1588: Entity events - transactionsClosedRadek Tomiška03/28/2019

Actions
Actions #1

Updated by Vít Švanda almost 6 years ago

  • Related to Task #1534: Incremental account management and provisioning added
Actions #2

Updated by Vít Švanda almost 6 years ago

  • Target version changed from Pyrite (9.5.0) to Quartz (9.6.0)
Actions #3

Updated by Vít Švanda over 5 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Vít Švanda over 5 years ago

I implemented async for role-request (NOTIFY).
It works, but I have some issues with transaction (when exception is occure).

Actions #5

Updated by Vít Švanda over 5 years ago

  • Execution of role-request async implemented (using NOTIFY).
  • Problem with save state and exception to the role-request (outside the rollbacked transaction) I solved by modifing EntityManager. I added new interface for service ExceptionProcessable. If service for owner of event implemented this interface, then is exception propagated.
  • Problem with transaction is more complex. I created new issue for it #1588, but for this feature (role-request) works rollback correctly (if transaction is enabled in EntityManager -> now is disabled!).

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/a4f50b064a8f298e9c8ea6af49de2192f1059063

Actions #6

Updated by Vít Švanda over 5 years ago

  • % Done changed from 0 to 80

Frontend UX improvements:

  • Start request - sync vs accepted response implemented
  • Messages on start of request improved.
  • Log on the request detail moved down.
  • Detail of request stay open on error.
  • Refresh buttons added on the identity-roles detail.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/3c42870e70512113c145c0ff7eb65b83ebcc27df

Actions #7

Updated by Vít Švanda over 5 years ago

Actions #8

Updated by Vít Švanda over 5 years ago

Actions #9

Updated by Vít Švanda over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 80 to 90

I added test for async execution of request for case when exception occurred.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/f0dd03b3f994c026286779e9fb871d14c2ead367

Actions #10

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

I did test and review, it works and code looks nice, thx!

I merged feature into develop. I will continue with #1588.

Actions #11

Updated by Radek Tomiška over 5 years ago

  • Related to Task #1588: Entity events - transactions added
Actions #12

Updated by Vít Švanda over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF