Defect #1524
closed
Remove role mapping doesn't set historical values for merge
100%
Description
Use case:
role mapping has only one attribute mapping eq. ldapGroups. This attribute is multivalued and has strategy merge. When user remove directly all role mapping. Controlled merge value is still in controlled values and historical flag isn't set.
Workaround:
for first remove mapped attribute and then remove all role mapping.
Affected version <9.x.x
Updated by Ondřej Kopr about 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Vít Švanda
- % Done changed from 0 to 90
Delete method for role system was refactored and now use for deleting attributes service. The original delete method from repository was marked as deprecated. Test is included.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/1f6cc37e32f2e5953affaafc94f986c6c62ac5dc (branch: develop)
Please Vitek could you make a review? Thank you.
Updated by Vít Švanda about 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondřej Kopr
- % Done changed from 90 to 100
I did review. Works perfectlly, thanks for that.
- I added check on exists Id of deleted system-role.
- LRT for recalculation of controlled values was executed only on save or update. I added supports for starting this LRT on delete too.
https://github.com/bcvsolutions/CzechIdMng/commit/30ddc851b8104f1c946052208f186398a4f084f7