Project

General

Profile

Actions

Defect #1513

closed

Fix enumation usage in filter - filter does'nt work

Added by Alena Peterová almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
High
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
Start date:
02/18/2019
Due date:
% Done:

100%

Estimated time:
4.00 h
Affected versions:
Owner:

Description

Tested on version: 9.3.4

The filter "Sending status" doesn't work correctly - if I select "Not sent", all items are returned (see screenshot). If I select "Send", no items are returned.
Also please change the value in the select box from "Send" to "Sent".


Files

emails_history_filter.png (40.7 KB) emails_history_filter.png Alena Peterová, 02/18/2019 02:48 PM

Related issues

Related to IdStory Identity Manager - Defect #1546: Filter not working (OrgUnit detail, Users tab)ClosedRadek Tomiška03/08/2019

Actions
Actions #1

Updated by Alena Peterová almost 6 years ago

  • Tracker changed from Task to Defect
  • Description updated (diff)
Actions #2

Updated by Radek Tomiška almost 6 years ago

  • Status changed from New to In Progress
  • Target version set to Pyrite (9.5.0)
Actions #3

Updated by Radek Tomiška almost 6 years ago

  • Priority changed from Normal to High
  • Estimated time set to 4.00 h

This issue occurs, when filter is previously persisted in redux - e.g. show email table, use filter on email state (it's ok) - switch to identites content - return to email table - use filter (it's broken as description says).
This issue affects all enumerations used in filter.

Actions #4

Updated by Radek Tomiška almost 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90

I fixed using enumerations in filters (~using symbols). All filters should have to use redux value correctly now.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/1be32c687e57018420abb0e375305072f94f03e0

Could you do a feedback, please?

Actions #5

Updated by Alena Peterová almost 6 years ago

I have similar problem with filter on "History of worfklow processes" tab - filtering by workflow definition doesn't work. Is it the same issue as this?

Actions #6

Updated by Radek Tomiška almost 6 years ago

The issue with "History of worfklow processes" filter is not related with this ticket (it's not enumeration), but i fixed it too - the cause was a wrong filter property name:

https://github.com/bcvsolutions/CzechIdMng/commit/b3883c90938a1e1a53b2b00e90e2497bd583fee8#diff-22e783f84935f88c0cb137b7db4af0a8

Actions #7

Updated by Radek Tomiška almost 6 years ago

  • Subject changed from E-mails history - filter by "Sending status" doesn't work to Fix enumation usage in filter - filter does'nt work
Actions #8

Updated by Radek Tomiška almost 6 years ago

  • Related to Defect #1546: Filter not working (OrgUnit detail, Users tab) added
Actions #9

Updated by Vít Švanda almost 6 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I reviewed this and it works correctly (tested in the Chrome and IE11 too). Thanks for fix.

- I added translated Send to Sent.
https://github.com/bcvsolutions/CzechIdMng/commit/e0f2ace9bb814b9f1ae03a5d243ac3e43db322f8

Actions #10

Updated by Radek Tomiška almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF