Project

General

Profile

Actions
Copy link

Task #1512

closed

Feature approve terms block doesn't send value

Added by Ondřej Kopr about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Target version:
2.2.0
Start date:
02/18/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

EAV detail can't be saved because approve terms need be checked and after check this renderer doesn't return value to form.

This is probably block for project that use this feature.

Affected version 2.x.x

In version before 2.x.x isn't this problem because this renderer doesn't exist. Probably best solution for this is return value from the renderer AgreeCheckboxRenderer

Files

terms_error.gif (1020 KB) terms_error.gif Ondřej Kopr, 02/18/2019 11:14 AM
Actions
Copy link
 #2

Updated by Radek Tomiška about 5 years ago

  • Assignee set to Peter Štrunc
Actions
Copy link
 #3

Updated by Ondřej Kopr about 5 years ago

  • Status changed from New to In Progress
  • Assignee changed from Peter Štrunc to Ondřej Kopr
  • Target version set to 2.2.0
Actions
Copy link
 #4

Updated by Ondřej Kopr about 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

I update renderer AgreeCheckboxRenderer with same behavior as BooleanFormAttributeRenderer. Now it works correctly. The changes was tested on verison 9.3.4, 9.4.0 and 9.6.0-SNAPSHOT.

Please Radek could you make a review? We can do review together and check the new behavior on my local environment.

Commit: https://git.bcvsolutions.eu/modules/reg/commit/b2b5d4f77a37abab2cd1d08d2ca0d2bd89bd17c6 (branch: develop)

Actions
Copy link
 #6

Updated by Radek Tomiška almost 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did test and code review, it works, thx!

Note: I installed module on existing environment, where previous version of this module was installed. I fixed some issues unrelated with this ticket - but i think backward compatibility not work correctly anyway (new form is not inited completelly, password field is required in each update ...) :-/

https://git.bcvsolutions.eu/modules/reg/commit/0c4b2476ff7d3dc6c224de3bbfc987a9696ed471

Actions
Copy link
 #7

Updated by Ondřej Kopr almost 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #8

Updated by Ondřej Kopr almost 5 years ago

Radek Tomiška wrote:

I did test and code review, it works, thx!

Note: I installed module on existing environment, where previous version of this module was installed. I fixed some issues unrelated with this ticket - but i think backward compatibility not work correctly anyway (new form is not inited completelly, password field is required in each update ...) :-/

https://git.bcvsolutions.eu/modules/reg/commit/0c4b2476ff7d3dc6c224de3bbfc987a9696ed471

For update behavior with password fields was created ticket #1677

Actions
Copy link

Also available in: Atom PDF