Project

General

Profile

Actions
Copy link

Feature #1497

closed

New toDto method with filter for dto services

Added by Ondřej Kopr almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Dto mapping
Target version:
Opal (9.4.0)
Start date:
02/12/2019
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Now isn't possible put filter into toDto method. Please create new toDto method with third parameter.

The new method toDto will call the original toDto method (backward compatibility).

In this ticket please check and allow fill dtoClass in DataFilter. The attribute can be used in new toDto method.

This changes MUST be mentioned in changelog. Because toDto line will have new step.

Related issues

Related to IdStory Identity Manager - Feature #1498: Identity role audit (new audit for all sub entities)ClosedOndřej Kopr02/12/2019

Actions
Actions
Copy link
 #1

Updated by Ondřej Kopr almost 6 years ago

  • Related to Feature #1498: Identity role audit (new audit for all sub entities) added
Actions
Copy link
 #2

Updated by Ondřej Kopr almost 6 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Ondřej Kopr almost 6 years ago

  • % Done changed from 0 to 60

I create new methods:

  • DTO toDto(E entity, DTO dto, F filter)
  • Page<DTO> toDtoPage(Page<E> entityPage, F filter),
  • List<DTO> toDtos(List<E> entities, boolean trimmed, F filter)

All these methods are last in whole line and methods contain behavior from previous method. This change must be consult with someone who made these methods.

Otherwise I'm done. And done as done :)

Actions
Copy link
 #4

Updated by Ondřej Kopr almost 6 years ago

  • % Done changed from 60 to 40

Ouh, the change with method toDto wasn't good. Some services are problematic.

Actions
Copy link
 #5

Updated by Ondřej Kopr almost 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 40 to 90

After long consultation I finally finish the last issues. Thanks for all consultation. The final solution is with new method that return true/false.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/922147f6ad34c80ccba274ace01f7823d0b29dcf (branch develop)

Please Radek could you check this ticket and the solution? Thank you.

Actions
Copy link
 #6

Updated by Radek Tomiška almost 6 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did code review, it looks nice, thx!

Actions
Copy link
 #7

Updated by Ondřej Kopr almost 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF