Feature #1497
closed
New toDto method with filter for dto services
100%
Description
Now isn't possible put filter into toDto method. Please create new toDto method with third parameter.
The new method toDto will call the original toDto method (backward compatibility).
In this ticket please check and allow fill dtoClass in DataFilter. The attribute can be used in new toDto method.
This changes MUST be mentioned in changelog. Because toDto line will have new step.
Related issues
Updated by Ondřej Kopr about 5 years ago
- Related to Feature #1498: Identity role audit (new audit for all sub entities) added
Updated by Ondřej Kopr about 5 years ago
- % Done changed from 0 to 60
I create new methods:
- DTO toDto(E entity, DTO dto, F filter)
- Page<DTO> toDtoPage(Page<E> entityPage, F filter),
- List<DTO> toDtos(List<E> entities, boolean trimmed, F filter)
All these methods are last in whole line and methods contain behavior from previous method. This change must be consult with someone who made these methods.
Otherwise I'm done. And done as done :)
Updated by Ondřej Kopr about 5 years ago
- % Done changed from 60 to 40
Ouh, the change with method toDto wasn't good. Some services are problematic.
Updated by Ondřej Kopr about 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 40 to 90
After long consultation I finally finish the last issues. Thanks for all consultation. The final solution is with new method that return true/false.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/922147f6ad34c80ccba274ace01f7823d0b29dcf (branch develop)
Please Radek could you check this ticket and the solution? Thank you.
Updated by Radek Tomiška about 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
I did code review, it looks nice, thx!