Project

General

Profile

Defect #1472

Disabled Attribute with password was provisioned

Added by Alena Peterová 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Password
Target version:
Start date:
01/23/2019
Due date:
% Done:

100%


Description

Version: 9.3.4-SNAPSHOT

Steps to reproduce:
In the provisioning mapping:
  • the attribute AttrPass is "Attribute with password"
  • set the attribute to "Disabled"
  • change the password for the system for some user
  • the attribute AttrPass was provisioned to the system during the password change

Related issues

Related to CzechIdM - Task #1494: Password change - remove accounts without enabled password from selection New 02/07/2019

History

#1 Updated by Alena Peterová 6 months ago

  • Description updated (diff)

#2 Updated by Ondřej Kopr 6 months ago

  • Status changed from New to In Progress
  • Target version set to Opal (9.4.0)

#3 Updated by Ondřej Kopr 6 months ago

  • % Done changed from 0 to 60

Before password change for AccAccountDto is now checked allowed password attributes. If any password attribute isn't founded password changed for this account failed.

For example:

I have system with 2 mapped passwords (PASSWORD and description). PASSWORD is defined as main password, now exists four use cases:

  1. Both attributes are enabled -> password change are success (both attributes are provisioned),
  2. description attribute is disabled -> password change are success (only PASSWORD is changed),
  3. PASSWORD is disabled - > password change are success (only description is changed), EVEN description is mapped as secondary password,
  4. both attributes are disabled -> password change failed (no attributes are provisioned).

Test missing.

#4 Updated by Ondřej Kopr 6 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Alena Peterová
  • % Done changed from 60 to 90

Please Alca do you have time for check my changes? For your better testing I deployed whole develop into virtual http://172.31.255.96:8080/idm/ you can use this enviroment. Not now.

Also check use cases (comment 3) if this is OK. You dont have to do code review, this probably do Radek or Vitek, but if you want :D.

Thank you.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/af203cbcf3bd0771115ba1fbd7af3e1a85a74bfb (develop)

#5 Updated by Vít Švanda 5 months ago

  • Assignee changed from Alena Peterová to Radek Tomiška

#6 Updated by Radek Tomiška 5 months ago

  • Related to Task #1494: Password change - remove accounts without enabled password from selection added

#7 Updated by Radek Tomiška 5 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did test and review, it works as UC above says. Code looks nice.

Note: i created ticket #1494 - hide accounts from select box on password change contents, when all password fields are disbaled (=> prevent to show exception with not executed password change).

#8 Updated by Ondřej Kopr 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF