Project

General

Profile

Feature #1438

Validators for EAV attributes

Added by Ondřej Kopr 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Validators
Target version:
Start date:
01/09/2019
Due date:
% Done:

100%


Description

For all eavs attributes will be implemented new feature validators.

Now will works these validation:

  • required,
  • regex,
  • min,
  • max,
  • unique.

For validators will works prefly validation.

Validation will be implemented for IdmFormAttribute and overridden attribute in role.

Validators will not works for multivalued attributes.


Related issues

Related to CzechIdM - Task #1408: Use regular expression as validator in EAV Closed 12/07/2018

History

#1 Updated by Ondřej Kopr 4 months ago

  • Assignee changed from Ondřej Kopr to Radek Tomiška

Please do it. Probably immediately.

#2 Updated by Ondřej Kopr 4 months ago

  • Related to Task #1408: Use regular expression as validator in EAV added

#3 Updated by Radek Tomiška 4 months ago

  • % Done changed from 0 to 30

Basic BE validation are implemented. Validation error sent from BE is rendered as standard FE field validation. Remains implementing all types of validations (required implemented now).

#4 Updated by Radek Tomiška 4 months ago

  • % Done changed from 30 to 50

Implemented all validation types on BE - min, max, regex, unique.

I'll continue with:
- showing better error message on FE for regular expressions
- prevent to lost filled values, when some validation fails (after request to BE)

#5 Updated by Radek Tomiška 4 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 50 to 90

Feature is implemented:
- the simple validations - required, min, max - are still evaluated on FE, when value is changed
- regex, unique validations are evaluated after form is saved on BE
- validation can be overriden in role form attributes

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/596464aeee7484a7667bbb85de783eb5c4b8d1bf

Doc:
https://wiki.czechidm.com/devel/documentation/application_configuration/dev/dynamic-forms#validation

Could you do a feedback, please?

#6 Updated by Vít Švanda 3 months ago

I did review and everything looks correctly now (I completed copy of validation definitions to role attributes and I created tests for it).

I discovered only one potencial problem: In the case, when user creates two concept-role for same role where unique validation is enabled. In this case, user can create concepts with same value (not unique). Be default it is correct, because unique check should be executed against in the identityRole values. As future improvement could be implemented validation on unique EAV values whitin specific role-request.

Thanks for that.

Changes and tests: https://github.com/bcvsolutions/CzechIdMng/commit/f5551d9a645ef794d3c3371a4fe5e490d5c1352d

#7 Updated by Vít Švanda 3 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

#8 Updated by Radek Tomiška 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF