Task #1405
closed
Modify Workflow sync Ldap groups
100%
Description
In workflow change default validity of roles assigned based on membership in LDAP to null and assigne this membership to all valid contracts or valid in future.
Related issues
Updated by Vít Švanda over 5 years ago
May be it is good time for move that workflow from product to the Extras module.
Updated by Marcel Poul over 5 years ago
- Related to Task #1268: Improve the AD group synchronization workflow added
Updated by Peter Štrunc over 5 years ago
I saw it working. Issues found were fixed. Please add possibility to create all roles in one defined catalogue.
Updated by Ondřej Kopr over 5 years ago
- Target version changed from Onyx (9.3.2) to Opal (9.4.0)
Updated by Patrik Stloukal over 5 years ago
- Status changed from New to In Progress
- Assignee changed from Patrik Stloukal to Vít Švanda
- % Done changed from 0 to 90
I added possibility to create all roles in one defined catalogue, modified documentation (https://wiki.czechidm.com/tutorial/dev/ad_groups_sync_workflow?s[]=workflow&s[]=groups#set_aplication_properties), and i tested this new feature on ours AD system.
commits: https://github.com/bcvsolutions/CzechIdMng/commit/5bd39341e6dee36daae146dce9c8626da9ed2945
https://github.com/bcvsolutions/CzechIdMng/commit/fc2397f8b74838a41921109655e421d233363a46
Vít please look on this new version, it should be ok
Updated by Vít Švanda over 5 years ago
- Status changed from In Progress to Needs feedback
Updated by Vít Švanda over 5 years ago
- Target version changed from Opal (9.4.0) to Opal (9.4.0-rc.2)
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Patrik Stloukal
I did code review.
- For the next time, please avodi using the fix method order in tests (@FixMethodOrder + methods with prefix n1... is not nice).
- For the next please create the pull request.
- In code of WF are some places from whitch I am not happy:
- Why are variables named as constants (CREATE_ALL_ROLES_TO_ONE_CATALOGUE....),
- :-) logItem.addToLog("loooooool " + attr.getName()); ??
- For joining a strings we using MessageFormat not "+".
Updated by Vít Švanda over 5 years ago
- Target version changed from Opal (9.4.0-rc.2) to Opal (9.4.0)
Updated by Patrik Stloukal about 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Patrik Stloukal to Vít Švanda
ok, i made changes (above),
I tel these variables named as that, because I wanted to keep changes (in code) to minimum. Maybe it was not the best in this situation.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/0fa53a2f64ba96081160140dcc0de3eec59fe98c
Please look on this again.
Updated by Vít Švanda about 5 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Vít Švanda to Patrik Stloukal
- % Done changed from 90 to 100
It looks better. Merged in the develop.
Updated by Vít Švanda about 5 years ago
For hide the previous version of this workflow you can change it's category:
- Change category in the workflow xml definition with code 'syncRoleAd'.
- Or you can also use update in DB ( UPDATE act_re_procdef set category_='eu.bcvsolutions' where key_='syncRoleAd';).