Project

General

Profile

Defect #1395

Fix last expired contract by specific identity

Added by Ondřej Kopr 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Contractual relationship
Target version:
Start date:
11/30/2018
Due date:
% Done:

100%


Description

Method IdmIdentityContractService#findLastExpiredContract filtering expired contract but for all identities not for specific identity.

History

#1 Updated by Alena Peterová 8 months ago

Effect: Synchronization of protection mode (#1225) in the mode "Link protected" would compute badly the account protection end for identities, that are inactive. It will use the date of the last expired contract in the whole IdM, not of the contract of that inactive identity. Also it would be slow.
Sorry, guys.

#2 Updated by Ondřej Kopr 8 months ago

  • Status changed from New to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

I add new method into repository (backward compatibility) and change behavior in method IdmIdentityContractService#findLastExpiredContract. Test is included.

Coomit: https://github.com/bcvsolutions/CzechIdMng/commit/791c40e151a7ed0a7731b759e54be6e3336fd2ed (branch develop)
Please Radek could you make a review?

#3 Updated by Radek Tomiška 8 months ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did review and test, it works, thx!

#4 Updated by Ondřej Kopr 8 months ago

  • Status changed from Resolved to Closed

#5 Updated by Alena Peterová 8 months ago

  • Target version changed from Opal (9.4.0-rc.1) to Onyx (9.3.1)

The fix was cherry-picked to hotfix-9.3.1.

Also available in: Atom PDF