Task #1373
closed
Add more comparison methods to automatic roles with attribute
100%
Description
I want create automatic rule on String attribute in case if this attribut contains substring
e.g. attribute titleBefore contains MuDr.
maybe add ignore case option
- starts with
- is empty (null or empty string/list)
- (not) ends with
- not equals
- lesser then (in case of numeric data types)
- greather then (in case of numeric data types)
- (not) contains
Updated by Vladimír Kotýnek over 4 years ago
- Subject changed from Add contains comparison to automatic roles with attribute to Add more comparison methods to automatic roles with attribute
- Description updated (diff)
Updated by Zdeněk Burda over 4 years ago
- Due date set to 02/05/2020
- Priority changed from Normal to High
- Target version set to 10.1.0
- Estimated time set to 24.00 h
Updated by Vít Švanda over 4 years ago
- Description updated (diff)
- Estimated time changed from 24.00 h to 32.00 h
Updated by Ondřej Kopr over 4 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 10
Updated by Ondřej Kopr about 4 years ago
- % Done changed from 10 to 40
Final solutions with EAVs and multivalued. For now will be available only equals, is empty and is not empty strategies for multivalued EAVs. Another strategies will not be able for chosen by fronted agenda for multivalued.
Now is successfully implemented strategies: is not empty and equals. Now I will continue with is empty.
Updated by Ondřej Kopr about 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 40 to 80
Implementation new comparison methods for automatic roles by attribute was completed.
Whole implementation can be found in branch okopr/1373-add-comparsion-methods-to-automatic-roles compare: https://github.com/bcvsolutions/CzechIdMng/compare/develop...okopr/1373-add-comparsion-methods-to-automatic-roles
For every new comparison exists test with several usecases.
Tested on postgres 11.2 and 9.6
Missing:- test on MsSQL,
- documentation,
- performance test (tests for contains are maybe little bit slower than I except).
Please Radek could you provide me first feedback? Tests on your environment and with your DB? I check mssql and performance. (+documentation) Thank you for this first part of review :)
Updated by Ondřej Kopr about 4 years ago
- % Done changed from 80 to 90
Documentation: https://wiki.czechidm.com/devel/documentation/roles/dev/automatic-roles-by-attribute#rules
Performance test: https://wiki.czechidm.com/devel/documentation/roles/dev/automatic-roles-by-attribute-performance
Test for MsSQL was also done and it works.
Updated by Radek Tomiška about 4 years ago
- Status changed from Needs feedback to Resolved
- % Done changed from 90 to 100
I did test and code review, we made changes agile way (confidential atributes not supported, performance test) and it works. This feature is very complex, good job.
Merged into develop.
Updated by Ondřej Kopr about 4 years ago
I updated information about performance tests and queries cost. Thank you for help me with exists subquery. Difference with changed behavior is big for example: max explain is now 39.51 and previous max was 88237.81.
Updated by Radek Tomiška about 4 years ago
- Status changed from Resolved to Closed