Project

General

Profile

Actions

Defect #1364

closed

ProvisioningOperationReportExecutor doesn't check multivalued attributes

Added by Ondřej Kopr over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Report
Target version:
Start date:
11/07/2018
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

While is composed values from the report it can be thrown exception because call getValue method on multivalued isn't possiblem. Please check isMultivalued

Affected version < 9.3.0-SNAPSHOT

Actions #1

Updated by Ondřej Kopr over 5 years ago

  • Target version set to Onyx (9.3.0)
Actions #2

Updated by Ondřej Kopr over 5 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30

I fixed the problem, but now I must create test for multivalued attributes :(

Actions #3

Updated by Ondřej Kopr over 5 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 30 to 90

I made last changes in tests and everything works, please Radek could you make a review? The biggest change is in tests, because I create test LDAP with memberOf attribute (the attribute is created by ldif). The ldap server will be moved/copied to acc model.

Thank you for review, there is commit:

update: https://github.com/bcvsolutions/CzechIdMng/commit/5b1db04c8e53b5688ed80f4daa23fd5d79432ab2
tests+ldap: https://github.com/bcvsolutions/CzechIdMng/commit/fc0d2905448dc1891a26d2472082b0e1543831ee

Actions #4

Updated by Radek Tomiška over 5 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

I did test and review, it works and code looks nice!

Specially thx for then LDAP tests, will be usable in other places too :)

Actions #5

Updated by Ondřej Kopr over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF