Task #134
closed
Role detail on single detail content with tabs
Added by Radek Tomiška over 8 years ago.
Updated about 8 years ago.
Estimated time:
(Total: 0.00 h)
Description
Now is role detail implemented by modal window. Role will be extended and is necessary to rewrite detail to solo content (e.g. organization detail):
- new navigation item in module descriptor
- new tabPanel with one tab item now - Basic information (e.g. identity profile)
- new route
- Status changed from New to In Progress
- % Done changed from 0 to 80
- % Done changed from 80 to 90
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
Implementation:
- new tab for role (Basic information)
- new route
- add components - RoleDetail, Content and Role with tab panel.
Please do code review and report me every problem you found. Thanks
TODO: fix problem with role type filter.
- Related to Defect #135: Selected role type is not saved added
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 80
It works nice and smoothly. I've made code review, code looks nice, i've found some issues:
- security access for detail route should be defined to ROLE_READ (the same as parent route need to be changed)
- security access for role-tabs and role-detail navigation should be defined to ROLE_READ.
- remove please poarameter userID from TabPanel component and replace it to entityID on user detail (and profile etc.) - entityID will be used instead userID parameter.
- props activeItem (selectedSidebarItem) in TabPanel comonent is hard coded now to work with second navigation level only - could be refactored and can be controlled by parentId and selectedNavigationItems parameters.
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
BE:
- Access for detail change to ROLE_READ
- Tabs and navigation changed to ROLE_READ
Parameter userId will changed in taks #141 , refactor props activeItem will changed in same task.
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
Also available in: Atom
PDF
