Task #1334
closed
Create extras module
100%
Description
The goal of this ticket is to develop a CzechIdM extras module and add its first feature - Virtual system import LRT
Updated by Peter Štrunc over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Ondřej Kopr
- % Done changed from 0 to 80
I created the module using archetype and added Virtual system import LRT.
Documentation is available here : https://wiki.czechidm.com/devel/documentation/modules_extras
there is not much now, but it will grow, as we add more features.
Implementation is in https://github.com/bcvsolutions/czechidm-extras in develop branch
Can you please do review? Thanks
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Ondřej Kopr to Peter Štrunc
- Target version deleted (
Morganite (9.2.2))
I have a few comments:
- The basic structure of the module is not correct "czechidm-extras/Realization/czechidm-extras/Realization/backend/idm-extras /" -> "czechidm-extras/Realization/backend/idm-extras/".
- The extra module is not part of the product, it is necessary to create an extra project for it in redmine. The module has its own version and is not in 9.2.2.
- No localization and tests was transferred for feature "import to system".
Updated by Vít Švanda over 5 years ago
- Project changed from IdStory Identity Manager to extras
- Category deleted (
Modularity)
Updated by Peter Štrunc over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Vít Švanda
I fixed all of the issues in previous comment. Could you please review the changes? Thank you
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Peter Štrunc
It looks OK. Only gitignore missing, so configuration file for Idea "iml", target folder and src/doc exists in the Git now.
This could help: https://github.com/bcvsolutions/idm-module-archetype/blob/develop/Realization/backend/idm-archetype/src/main/resources/archetype-resources/.gitignore
After add gitignore, please close this ticket.
Updated by Peter Štrunc over 5 years ago
- Status changed from In Progress to Closed
- % Done changed from 80 to 100
I removed unwanted files and added gitignore file.