https://redmine.czechidm.com/https://redmine.czechidm.com/themes/purplemine2/favicon/favicon.ico?16339658642018-09-18T09:04:51ZIdStory Identity ManagerIdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=61722018-09-18T09:04:51ZOndřej Kopr
<ul><li><strong>Subject</strong> changed from <i>Generate values during create identity</i> to <i>Generate values during create entity</i></li></ul> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=61792018-09-19T04:57:42ZOndřej Kopr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=61852018-09-20T07:59:46ZOndřej Kopr
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/1261">Feature #1261</a>: Supports AbstractDto as entity type in processors</i> added</li></ul> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=61872018-09-20T08:01:51ZOndřej Kopr
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>10</i></li></ul><p>New entity IdmGeneratedAttributes was create - service, controller, repository, dto, ....<br />New manager that supports generating and get supported types was created.<br />New interface and abstract class for generators - ValueGenerator, was created.</p>
<p>Now I start with implement frontend agenda.</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62042018-09-24T07:20:22ZOndřej Kopr
<ul><li><strong>% Done</strong> changed from <i>10</i> to <i>30</i></li></ul><p>Frontend agenda was implemented. Now is possible made CRUD operation from frontend.</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62102018-09-24T07:52:12ZOndřej Kopr
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/1267">Task #1267</a>: Support save EAV with Entity</i> added</li></ul> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62322018-09-26T08:00:36ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/1272">Task #1272</a>: Eav attribute - default value as placeholder</i> added</li></ul> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62342018-09-26T08:08:00ZOndřej Kopr
<ul><li><strong>% Done</strong> changed from <i>30</i> to <i>60</i></li></ul><p>Basic implementations with 3 generators and tests for it are complete. Now I start with implement generator for EAV values (EAV constant and EAV default values)</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62672018-09-28T06:57:43ZOndřej Kopr
<ul></ul><p>Basic implementations with defaults generators and tests for it are complete. I made some changes after colleague's feedback:</p>
<ul>
<li>I remove generator for EAV constant, second EAV generator 'default values' still exists,</li>
<li>add settings for username generator - use first firstname or lastname,</li>
<li>email generator now extends username generator and works with same behavior,</li>
<li>generators with order 0 - 10 can be set only by system from admin interface its not possible, check was added into controller,</li>
<li>localization was fixed,</li>
<li>some default values for generator settings was changed</li>
</ul> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62682018-09-28T10:47:15ZOndřej Kopr
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> changed from <i>Ondřej Kopr</i> to <i>Radek Tomiška</i></li><li><strong>% Done</strong> changed from <i>60</i> to <i>80</i></li></ul><p>Tests was updated. Please Radek could you made a part of review? Works:</p>
<ul>
<li>generators behavior and agenda works,</li>
<li>tests,</li>
<li>er diagram,</li>
<li>changelog.</li>
</ul>
thinks to be done:
<ul>
<li>Documentation - now exists only some introduce,</li>
<li>create new default EAV value generator when IdM init,</li>
<li>check if email exists - now isn't possible check this, because filtering by email doesn't exist. I haven't time to implement this filtering.</li>
</ul>
<p>Branch: <a class="external" href="https://github.com/bcvsolutions/CzechIdMng/tree/okopr/1259-generated-values">https://github.com/bcvsolutions/CzechIdMng/tree/okopr/1259-generated-values</a><br />compare: <a class="external" href="https://github.com/bcvsolutions/CzechIdMng/compare/okopr/1259-generated-values">https://github.com/bcvsolutions/CzechIdMng/compare/okopr/1259-generated-values</a></p>
<p>Thank you :-) And please don't merge the branch, I have some feedback for discuss with you guys. Thank you.</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62822018-10-02T14:53:39ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Ondřej Kopr</i></li></ul><p>I did test and review. Feature works, thx!</p>
I fixed / changed + notes:
<ul>
<li>i fixed change script for postgresql (binary, datetime type not exist, generator_properties missing in audit table) and used actual script number (V9_02_003)</li>
<li>index on entity was missing (just in change script)</li>
<li>i removed interface 'Generable' - supported dto types are loaded by registered generators. Dto is used for supported types => entities are not used for generators. All services was refactored.</li>
<li>after discussion we decide to rename some dtos and entities.</li>
<li>i don't understand, why cleverness with system seq was added:
<ul>
<li>i don't see a reason, why administrator should be limited this way?</li>
<li>and initialization of system generators is not implemented.</li>
<li>or why 'unmodifiable' flag wasn't used as on other places (e.g. eav attributes)?</li>
</ul>
</li>
<li>check seq for system generator moved to standard validation method</li>
<li>some result codes missing in localization (e.g. GENERATOR_RETURN_NULL ..)</li>
<li>enabled evaluator used instead module service (and it's used on right place in manager) - maybe all vs. available generator method can be added (e.g. when module is disabled, then previously configured generators are not shown properly)</li>
<li>some nice name can be used for generators (used in localization)</li>
<li>generateItem vs generate - remove please generateItem method (Assert.notNull(...) can be defined - if needed - in implementations). </li>
<li>parameter dtoType is not used in controller getAvailableGenerators method - remove it please for now (i don't know, if path parametr is suitable for it so we can add it in future)</li>
<li>filter on FE uses duplicate ref - move filter to standalone component (see notification filter)</li>
</ul>
<p>Commit:<br /><a class="external" href="https://github.com/bcvsolutions/CzechIdMng/commit/d57ea5f701f8f70807405d5ea79c08533cd30ee3">https://github.com/bcvsolutions/CzechIdMng/commit/d57ea5f701f8f70807405d5ea79c08533cd30ee3</a></p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62872018-10-03T08:52:21ZOndřej Kopr
<ul><li><strong>Assignee</strong> changed from <i>Ondřej Kopr</i> to <i>Radek Tomiška</i></li></ul><p>Thank you for fixing the issues with generates values. Please could you reimplement/implement the last issues, then I add documentation and it will be possible, close the ticket. Thank you Radek.</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62922018-10-03T12:57:50ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Ondřej Kopr</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>90</i></li></ul><p>I've implemented all notes and merge feature into develop.</p>
<p>Commit:<br /><a class="external" href="https://github.com/bcvsolutions/CzechIdMng/commit/4085ce46ae2148f04f55403e01e0553daa4f320d">https://github.com/bcvsolutions/CzechIdMng/commit/4085ce46ae2148f04f55403e01e0553daa4f320d</a></p>
<p>Could you do a feedback again and add doc, pls?</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=62942018-10-03T15:32:29ZOndřej Kopr
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>In Progress</i></li></ul><p>Thank you for fix issues and clean code. Behavior with unmodifiable is better than seq. Now missing only documentation.</p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=63802018-10-08T16:04:30ZOndřej Kopr
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>Documentation was created:</p>
<p><a class="external" href="https://wiki.czechidm.com/devel/documentation/generated_values">https://wiki.czechidm.com/devel/documentation/generated_values</a><br /><a class="external" href="https://wiki.czechidm.com/devel/documentation/generated_values/dev/generated_values">https://wiki.czechidm.com/devel/documentation/generated_values/dev/generated_values</a></p> IdStory Identity Manager - Task #1259: Generate values during create entityhttps://redmine.czechidm.com/issues/1259?journal_id=63852018-10-09T08:10:12ZOndřej Kopr
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-5 priority-2 priority-default prio-name-normal closed" href="/issues/890">Feature #890</a>: Generate login when saving a user</i> added</li></ul>