Task #1258
closed
Add to notification configuration disable option
100%
Description
On FE add disable option in Notification Configuration, add disable checkbox,
on BE update IdmIdentity and Dto and upgrade NotificationManager to not send disabled notifications.
Updated by Patrik Stloukal over 5 years ago
- Status changed from New to In Progress
- BE update IdmNotification and Dto
Updated by Patrik Stloukal over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Patrik Stloukal to Ondřej Kopr
- % Done changed from 0 to 90
I implement this feature, it is now not sending notification for disabled notification configurations.
I did not know that notifications without notification configurations are still sent, so i had to modified my code.
Please look on my implementation and write feedback.
commits: https://github.com/bcvsolutions/CzechIdMng/commit/e4b5830a927e7cf71980abad36f8879a7012d0cd
https://github.com/bcvsolutions/CzechIdMng/commit/e9a42ae7585ba69eacd1fcffa7f64cdc18d34abe
https://github.com/bcvsolutions/CzechIdMng/commit/e3f3ad86c680698863aa8b29040fcf031c603c51
Updated by Ondřej Kopr over 5 years ago
- Assignee changed from Ondřej Kopr to Radek Tomiška
Updated by Ondřej Kopr over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Patrik Stloukal
- % Done changed from 90 to 80
This definitely not work :( you didn't implement flyway script for postgresql and flyway script for sql server contains error. Please fix it first.
Updated by Patrik Stloukal over 5 years ago
- Assignee changed from Patrik Stloukal to Ondřej Kopr
- % Done changed from 80 to 90
oh, sorry my bad, that script was ment for postgres... i somehow misplaced this..
So i fixed this and created flyway script for sql server.
Could you check this again please?
commit: https://github.com/bcvsolutions/CzechIdMng/commit/fde9d6999ec7c2d8fdac25c130be03575a81da6f
Updated by Ondřej Kopr over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
Please Radek could you make a review? Thank you.
Updated by Ondřej Kopr over 5 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Patrik Stloukal
- % Done changed from 90 to 80
Notification is obsolete or missing, please add some information about new awesome feature disable notification:
https://wiki.czechidm.com/devel/documentation/notifications/dev/notification_manager
https://wiki.czechidm.com/tutorial/adm/notifications_topics
https://wiki.czechidm.com/tutorial/adm/notifications_standard
Updated by Radek Tomiška over 5 years ago
- Status changed from In Progress to Needs feedback
- % Done changed from 80 to 90
I had to rewrite it from scratch. Checking of disabled notification configuration was on wrong place => sender shouldn't check or resolve configuration again (=> issues with cyclic dependency). Configuration is resolved before and is used for sending notification as input.
Other issues fixed:
- ERD - added new column
- change script - fixed default value for new not null column
- Disableable interface added to configuration entity and dto
- localization for disabled field fixed - used common label and help added
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/eb4561fd3f463fa89830f1dffad34ef4430fa81a
Could you please do a feedback again and add documentation?
Updated by Patrik Stloukal over 5 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Patrik Stloukal to Radek Tomiška
- % Done changed from 90 to 100
I checked your implementation and it works, Thank you.
I wrote documentation: https://wiki.czechidm.com/devel/documentation/notifications/dev/notification_manager#disable_sending_notifications
and admin: https://wiki.czechidm.com/tutorial/adm/notifications_topics
Can be merged to develop.
And I am closing this ticket.