Project

General

Profile

Actions

Defect #1217

closed

Assigning and removing automatic role for invalid contract

Added by Alena Peterová over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Automatic roles
Target version:
Start date:
08/16/2018
Due date:
% Done:

100%

Estimated time:
Affected versions:
Owner:

Description

Version 8.1.2, tested also on version 7.7 (demo)

  • Identity has an invalid contract (validTill is in the past), the contract doesn't have workPosition
  • The organization "Org 1" has default role "AD" with recursion down.
  • The contract is set to the work position "Org 2", which is under "Org 1"
  • The identity gets the automatic role "AD" (disabled)
  • At night, the role "AD" is automatically removed by IdentityRoleExpirationTaskExecutor

This is strange - why is the role assigned for invalid contract, if it's removed later?
If we had "Forward account management,", would it create the account for that short period, or not?

We also tested, that if you create a new invalid contract with the workPosition "Org 2", the automatic role is not assigned. It is assigned only when the workPosition is null and then changed.

Actions #1

Updated by Radek Tomiška over 5 years ago

  • Tracker changed from Task to Defect
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions #2

Updated by Radek Tomiška over 5 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • Target version set to Jade (8.1.4)
  • % Done changed from 0 to 90

The problem was directly in the processor, which evaluates automatic roles by the tree nodes - condition for valid contract (now or in future), when work position changed was missing - fixed, tests added.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/93393f415fc87abb046f86143df1ad1b84b478e5

Could you do a feedback please?

Actions #3

Updated by Ondřej Kopr over 5 years ago

  • Assignee changed from Ondřej Kopr to Vít Švanda
Actions #4

Updated by Vít Švanda over 5 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

I tested this and now it works correctly. Thanks for that.

Actions

Also available in: Atom PDF