Project

General

Profile

Actions
Copy link

Task #1170

closed

Role - guarantee by role

Added by Radek Tomiška over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Roles
Target version:
Lapis (8.2.0)
Start date:
07/09/2018
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Role guarantee can be configured as identity select box. Add new tab for role guarantees to role detail, where guarantee can be configured by role select box:
- add new attribute to RoleGuarantee entity - targetRole (or create new entity)
- add new tab to role detail with role guarantee table

Actions
Copy link
 #1

Updated by Vít Švanda over 6 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Radek Tomiška over 6 years ago

I implemented new tab on role detail with role guarantees by role. Guarantees by identity is preserved as it is. I added new guarantees into filters for finding guarantees into WF and on identity detail - authorized roles.

Doc:
https://wiki.czechidm.com/devel/documentation/architecture/dev/events#entities_with_event_support

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/00fd71b3e9a4daf5601f346cf0d74f9005e17746

Could you please do a review?

Actions
Copy link
 #3

Updated by Radek Tomiška over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 0 to 90
Actions
Copy link
 #4

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Radek Tomiška

I did test and review. Code looks nice and everything works fine.

One potencial problem can be in the method loads all guarantees by role. This method is calls int the approving WF and for 6000 identities create of the process takes about 10 minuts (but everything works).

I suggest use the limit to first 100 guarantees (from that WF process).

Actions
Copy link
 #5

Updated by Radek Tomiška over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Vít Švanda

Thx for feedback, I agree. I've added pageable parameter to find guarantees method and use her in workflow with limit 100.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/6fe4d158bc8d4d1852c8fd0e12da0d74bf5e9dfb

Could you do a review again, pls?

Actions
Copy link
 #6

Updated by Vít Švanda over 6 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 90 to 100

That is much more better. For same example create of the task takes only 5s.

Thanks for that.

Actions
Copy link

Also available in: Atom PDF