Task #1156
closedAdd test for Example filter builder
100%
Description
Please add tests for filter buidler in example module.
Update documentation (tutorial)
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 90
I created new two tests for two filter builder. (Filter UsernameIdentityFilter has priority 10, this filter doesn't override filter from core, so I only check if override is correct).
commit: https://github.com/bcvsolutions/CzechIdMng/commit/3873f2a36bc4fdebdd0366d92dfef09c6d570d89 (branch: develop)
documentation:
https://wiki.czechidm.com/tutorial/dev/override_filter
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters
Please Radek could you made a review?
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 70
Refactor tests the same way as here:
https://github.com/bcvsolutions/CzechIdMng/blob/develop/Realization/backend/core/core-impl/src/test/java/eu/bcvsolutions/idm/core/model/repository/filter/UsernameIdentityFilterBuilderIntegrationTest.java
Filter builder only can be tested.
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 70 to 90
Thanks for hint with test only one filter. I little bit refactored tests:
commit: https://github.com/bcvsolutions/CzechIdMng/commit/5d451481b47237f3a1d52ac82017039bf4655112 (branch develop)
updated documentation:
https://wiki.czechidm.com/tutorial/dev/override_filter#create_test_for_filter
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#example_filter_test
Please Radek could you continue with feedback? Thank you.
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Thx, it's awesome :)
Note: I removed unnecessary login / out methods.