Project

General

Profile

Actions

Task #1156

closed

Add test for Example filter builder

Added by Ondřej Kopr over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Filters
Target version:
Start date:
06/27/2018
Due date:
% Done:

100%

Estimated time:

Description

Please add tests for filter buidler in example module.

Update documentation (tutorial)

Actions #1

Updated by Ondřej Kopr over 4 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Ondřej Kopr over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90

I created new two tests for two filter builder. (Filter UsernameIdentityFilter has priority 10, this filter doesn't override filter from core, so I only check if override is correct).

commit: https://github.com/bcvsolutions/CzechIdMng/commit/3873f2a36bc4fdebdd0366d92dfef09c6d570d89 (branch: develop)
documentation:
https://wiki.czechidm.com/tutorial/dev/override_filter
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters

Please Radek could you made a review?

Actions #3

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 70
Actions #4

Updated by Ondřej Kopr over 4 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 70 to 90

Thanks for hint with test only one filter. I little bit refactored tests:

commit: https://github.com/bcvsolutions/CzechIdMng/commit/5d451481b47237f3a1d52ac82017039bf4655112 (branch develop)

updated documentation:
https://wiki.czechidm.com/tutorial/dev/override_filter#create_test_for_filter
https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#example_filter_test

Please Radek could you continue with feedback? Thank you.

Actions #5

Updated by Radek Tomiška over 4 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Thx, it's awesome :)

Note: I removed unnecessary login / out methods.

Actions

Also available in: Atom PDF