Task #1135
closed
Bulk action improvements
100%
Description
The ticket contains improvements for bulk action:
- Change moduleService to ifEnabled,
- show and resolve prmission on FE,
- disable identity remove bulk action while is disable global delete,
- try more abstract (eq. getService and getEntityClass),
- move abstract class for bulk action to api.
Related issues
Updated by Ondřej Kopr over 6 years ago
- Status changed from New to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 90
Thanks Radek for hint and help there is changes parsed by commits:
- abstraction, there i had problem with message and topic constant, becouse Core desctriptors is in impl package. I add copy of the string and todo: https://github.com/bcvsolutions/CzechIdMng/commit/e88ae44c5e97e94239967d0c8b62e6be45bf6d0e
- resolve permissions on FE, this is little bit problem for me, please check method toBasePermissions in PermissionUtils if is OK the is main problem: https://github.com/bcvsolutions/CzechIdMng/commit/6cab927844a171d9443f3124f52152ce55c29f5a
- change module service to Enable annotation: https://github.com/bcvsolutions/CzechIdMng/commit/c477441cb9f3ba9991ac64935eb3c286ec0af37a
Commits are separated in branch: https://github.com/bcvsolutions/CzechIdMng/tree/okopr/1135-bulk-action-improvements
I also found little bug with find entities by user that has permission only to itself. Filtering by filter was done without propagate permission so bulk action was started for all founded by filter entities.
Next thing I fixed is showloading when user hasn't permission for own long running task. Now is show alert with info message.
After merge branch or commit/s to develop give me some info about it, I complete the task with add some information to changelog.
Please Radek could you check the improvements and made review?
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
It's nice, thx! Impelementing new bulk action is really simple and abstract remove action will be usefull!
I made just some rectoring (rename ...).
Updated by Radek Tomiška over 3 years ago
- Related to Defect #2743: Event: Start event remains in running state, when long running task ends with exception. added