Defect #1078
closed
Slow displaying of guarantees ends with an error
100%
Description
Affected version: 7.8.5
Please find attached the error which was displayed on the tab Guarantees.
When the tab is opened, the search in "Managers by tree structures" takes several seconds. After the search ends, the following message is shown.
There are 40 000 contracts.
Managers by tree structures are not used, this is turned off by following properties:
idm.sec.core.filter.IdmIdentity.managersFor.impl = eavCodeManagersFilter idm.sec.core.filter.IdmIdentity.subordinatesFor.impl = eavCodeSubordinatesFilter
In my local environment, I can't reproduce the error message, only the slow searching. Please could you try to find the reason of this bug?
Also if there is some better way to turn off managers by tree structures, let me know.
Files
Related issues
Updated by Alena Peterová over 6 years ago
If possible, please make the inactive guarantees gray in the tables "Direct guarantees on this contracted position" and "Managers by tree structures". So it will be clear at the first sight, that this guarantee will not be used in the processes (#1079#note-10)
Updated by Radek Tomiška over 6 years ago
Hm, i agree, i looked into criteria for finding managers and only "valid" identity can be manager - i think this is good. So i will add info about invalid guarantees in FE, as you says. I will leave algorithm unchanged, it's ok?
Updated by Alena Peterová over 6 years ago
Radek Tomiška wrote:
Hm, i agree, i looked into criteria for finding managers and only "valid" identity can be manager - i think this is good. So i will add info about invalid guarantees in FE, as you says. I will leave algorithm unchanged, it's ok?
We consulted it here and we agree :-)
Updated by Radek Tomiška over 6 years ago
- Related to Task #1108: Tree structure - turn off evaluating managers and subordinates added
Updated by Radek Tomiška over 6 years ago
- Status changed from New to Needs feedback
- Assignee changed from Radek Tomiška to Alena Peterová
- Target version set to Jade (8.1.0)
- % Done changed from 0 to 90
I implemented / fixed:
- managers filters - added missing condition, when contract was manually disabled or excluded - manager has to have valid contract (e.g. task should not be assigned to invalid identity).
- managers filters - added missing condition, valid identity only (manager could be disabled manually)
- added missing integration tests
- when manually added guarantees is disabled => gray row class added in the guarantees table.
- added number of valid managers into "Authorizers" column with link to contract detail (only if total number of managers is higher, than rendered - 10 by default)
- all filter queries were optimized - specially find subordinates by eav code (eavCodeSubordinatesFilter) - this is the reason of this issue, query takes to long and response was broken (cross joins, nested exists clausule ...).
- added new filters - find managers and subordinates by the direct guarantees only, doc https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#guaranteemanagersfilter (I suppose this filters will be configured mainly on projects)
- filter can be turn off by configuration, doc: https://wiki.czechidm.com/devel/documentation/architecture/dev/filters#filter_configuration
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/8ec7cc99d9cd0bdaac9418348e032c7e4e3dadd8
Could you do a feedback, pls?
Updated by Alena Peterová over 6 years ago
- Assignee changed from Alena Peterová to Radek Tomiška
Thanks for all the fixes, now the response is quick.
Please check the page User -> Subordinates. No directly set guarantee was displayed here, I tried all 3 subordinate filters. The managers filters worked well at the same time.
Also a very long text "Identity state. It's controlled by contracted positions or can be manually deactivated from the table actions." is now displayed in the filter on the page Users. It should be visible only in the help, not as placeholder in the field.
Updated by Alena Peterová over 6 years ago
Also special thanks for the new filter :)
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- % Done changed from 90 to 100
Thx for feedback!
ad User -> Subordinates) I forgot to add filter parameter, fixed
ad long text "Identity state...") fixed, I wanted to improve help, but I mixed it up :)
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/a8e174cd81d2dcd492332baff2ecce8fc40f9995
Updated by Radek Tomiška over 5 years ago
- Tracker changed from Task to Defect
- Category changed from 20 to Frontend