Project

General

Profile

Actions

Task #1075

closed

Synchronization duration sometimes not displayed properly

Added by Peter Štrunc about 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Ondrej Husník
Category:
Frontend
Target version:
Start date:
04/17/2018
Due date:
% Done:

100%

Estimated time:
Owner:

Description

If sync takes longer then one day, only the hour portion of duration is displayed in log, which is wrong.

Actions #1

Updated by Vít Švanda about 6 years ago

  • Assignee changed from Radek Tomiška to Vít Švanda

I do not show the number of days purposely. Format does not look very nice (1 22: 22: 0) and is not used anywhere.

Already earlier (version 8.0.0), I've improved this by adding a hummanized format in the tooltip above the duration of the sync. Behavior is the same as in LRT (days are also not show), except that the humanized format is displayed in the tooltip.

Showing the information that the sync is running 'few seconds' is not ideal here (in my opinion). But if you want (ideally "everyone" in Prague :-) ), I can change it and show humanized format as primary.

Actions #2

Updated by Vít Švanda about 6 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Vít Švanda to Peter Štrunc
Actions #3

Updated by Radek Tomiška almost 6 years ago

  • Priority changed from Normal to Low
  • Target version deleted (Jade (8.1.0))
Actions #4

Updated by Vít Švanda about 4 years ago

  • Assignee changed from Peter Štrunc to Ondrej Husník
  • Target version set to 10.1.0
Actions #5

Updated by Vít Švanda about 4 years ago

  • Status changed from Needs feedback to New
  • Target version changed from 10.1.0 to 10.2.0
Actions #6

Updated by Ondrej Husník about 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 70
Actions #7

Updated by Ondrej Husník about 4 years ago

  • Target version changed from 10.2.0 to 10.3.0
  • % Done changed from 70 to 50

Within this task there will be created a new FE component responsible for proper duration format. It will also display days in the format like this: "1d 10:05:03". If duration doesn't exceed 1 day, the day portion won't be displayed. Expected input will be: 'start' and 'stop' time in datetime format "2020-01-27T12:00:57.048+01:00"
This component will be also used in place of LRT.

Actions #8

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.3.0 to 10.4.0
Actions #9

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.4.0 to 10.6.0
Actions #10

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.6.0 to 10.4.0
Actions #11

Updated by Vít Švanda almost 4 years ago

  • Target version changed from 10.4.0 to 10.6.0
Actions #12

Updated by Ondrej Husník over 3 years ago

  • % Done changed from 50 to 80
Actions #13

Updated by Ondrej Husník over 3 years ago

  • Assignee changed from Ondrej Husník to Radek Tomiška
  • % Done changed from 80 to 90

I implemented a new component responsible for rendering time duration information. It shows the duration in the format HH:MM:SS if it's shorter than one day or with prefixed number of days i.e. 2d 12:23:30. It has an option 'humanForm' which switches whether to use the numeric or so called humanized form as the main. Humanized form may look like this: a day, 18 hours and so on. Regardless the humanForm settings, the "secondary" form is always displayed in the tooltip.

Please could you provide me a feedback?

https://github.com/bcvsolutions/CzechIdMng/commit/ce1993a9e2fa6675d4e3912577727c0c6d4cc3aa

Actions #14

Updated by Ondrej Husník over 3 years ago

  • Status changed from In Progress to Needs feedback
Actions #15

Updated by Radek Tomiška over 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 90 to 80

I did test and code review, component works and code looks nice, thx!

I found some minors:
- TimeDuration, ExportImportDetail, ReportTable - contain linter warning (unused import, code formatting).

And notes (can be solved optionally, by your point of view :)):
- TimeDuration - property ''humanForm'' could be renamed to ''humanized'' (it's proxy parameter only).
- TimeDuration - component use inited application context (see i18n) => component could be in advanced library (but a lot of our basic component brokes this design, so it depends on you :))

Actions #16

Updated by Ondrej Husník over 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Radek Tomiška

Thank you for your review. I removed all lint warnings and renamed 'humanForm' property to 'humanized' as you suggested.
I left the component among basic components.

https://github.com/bcvsolutions/CzechIdMng/commit/de01d52d64a46cd8122d9547e679a9689edffb78

Actions #17

Updated by Radek Tomiška over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 80 to 100

i did review again, it's awesome, thx!

Actions #18

Updated by Radek Tomiška over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF