IdStory Identity Manager

Only place where is this mistake is in service: DefaultIdmAutomaticRoleAttributeService method getRulesForContract, another places where is implemented pageable in automatic roles (ProcessAutomaticRoleByAttributeTaskExecutor) is pageable implemented correct. Thanks guys for help with debug.

Please Vitek could you made a review? Thank you :)

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/95ca42a015405d5897b453cb02e6e71b2fa3391f (branch hotfix/7.8.5)

I'm apologize all people for shorter describe of this problem, I'm not friend with documentation and English :D , I prefer to insert some code or commits and I read this code before I read some english description, but this is my personal priority. So there is some better describe of this problem:

In our application we are using spring data. Spring data has feature that allow paging and sorting record's/data obtained from repositories (eq. Pageable) This behavior is also good for performance improvements with iterate over many records (it's something like classic iterator in many other programming languages).

• contenct - FALSE (boolean property that filtering automatic roles in concept true/false),
• ruleType - Enumeration AutomaticRoleAttributeRuleType this enumeration is filtering by type of rules (IDENTITY, IDENTITY_EAV, CONTRACT, CONTRACT_EAV),
• hasRules - boolean property that filtering automatic roles that has minimal one rule,
• this isn't all filtering attribute, seeIdmAutomaticRoleFilter

Default page size for iterate over automatic roles in this case is 10 (this is defined in property: PROCESS_ROLE_SIZE).

Old behavior for this case:
In first 10 recordord obtained from repository is everything ok, filter and page request was used correctly and the result contains all record that we need. But in second interation is used again next page from previous request (this is correct), but this request doesnt contain filter, so result was filled with another contract and recalculation was longer, because recalculate was done even for automatic roles that hasn't any rules and etc. For better understanting problem you can see picture:

Finally solutions was easy for implementing, only changed thing was: propagate filter to next request. For future request dont forget: nextPageable returns size, sort, actual page, but doesn't return filtering paramaters!

I'm apologize for smaller description the problem. I'm not really friend with documentation and description.

I did review and test. It works fine, you are awesome. For next time please do shorter description I am not good reader.

Thank you I will fix it.

Next thing that it was repaired in this ticket is add entity type for recalculation automatic roles:

In processors IdentityAutomaticRoleProcessor and IdentityContractAutomaticRoleProcessor was add AutomaticRoleAttributeRuleType. AutomaticRoleAttributeRuleType is enumeration that is used in rules.

• contract - create, update: automatic rules that has minimal one rule with contract rule type CONTRACT,
• contract - eav_save: automatic rules that has minimal one rule with contract rule type CONTRACT_EAV,
• identity - create update: automatic rules that has minimal one rule with contract rule type IDENTITY,
• identity - eav_save: automatic rules that has minimal one rule with contract rule type IDENTITY_EAV.

This is new performance feature, now is after identity save recalculate only automatic roles that has at least one rule for identity.

Before :(

After :)