Task #1034
closed
Remove role request from automatic roles
100%
Description
Remove role request from all automatic roles (role tree node, automatic role) Roles will be assigned directly via identity role with new skip check authorities.
Related issues
Updated by Ondřej Kopr almost 7 years ago
- Related to Task #1032: Profiling CzechIdM (synchronization, recalculation, hr process) added
Updated by Ondřej Kopr almost 7 years ago
- % Done changed from 0 to 90
I removed role request from role tree node and automatic role attribute:
commit (branch hotfix/7.8.4):
https://github.com/bcvsolutions/CzechIdMng/commit/59da6148278b162d24fd9685cc94e305cad81e71
https://github.com/bcvsolutions/CzechIdMng/commit/6dc334f90f3d0b644b53cc80c73febcea4ff34cf
Any test wasn't changed.
Updated by Ondřej Kopr almost 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
Please Radek could you made a review? Test result from load test can be found in ticket #1032
Thank you :)
Updated by Radek Tomiška almost 7 years ago
- Assignee changed from Radek Tomiška to Ondřej Kopr
I did test and refiew, it works, thx.
Note:
I improved LRT for adding and removing automatic role by tree structure:
https://github.com/bcvsolutions/CzechIdMng/commit/d2a007d2200d06a61b4d88afbeb957f1928ae5ee
Improve 'ProcessAutomaticRoleByAttributeTaskExecutor' the same way if needed, or close this ticket if not.
Updated by Ondřej Kopr almost 7 years ago
- Assignee changed from Ondřej Kopr to Radek Tomiška
Thank you for feedback and sorry for some confusing methods.
I added behavior with failed entities and throw exception in LRT.
Example LRT result wit failed message:
eu.bcvsolutions.idm.core.api.exception.ResultCodeException: Automatic role [72dea55a-3963-4036-b92f-caf689a24c18] was not process correctly, failed contracts add: [], failed contracts remove: [ac655c2b-656e-4309-bd2a-621fd8c10712].
at eu.bcvsolutions.idm.core.scheduler.task.impl.ProcessAutomaticRoleByAttributeTaskExecutor.process(ProcessAutomaticRoleByAttributeTaskExecutor.java:134)
at eu.bcvsolutions.idm.core.scheduler.task.impl.ProcessAutomaticRoleByAttributeTaskExecutor.process(ProcessAutomaticRoleByAttributeTaskExecutor.java:1)
at eu.bcvsolutions.idm.core.scheduler.api.service.AbstractLongRunningTaskExecutor.call(AbstractLongRunningTaskExecutor.java:171)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at org.springframework.security.concurrent.DelegatingSecurityContextRunnable.run(DelegatingSecurityContextRunnable.java:80)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/5fc1cf590d9c62997a42f2d5d5d02ab0549b1d07 (branch: hotfix/7.8.4)
Updated by Radek Tomiška almost 7 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Thx, it looks nice!